Fixed the checking of available space #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make sense, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I just tried to deploy GOAD on a system which has multiple disks. While
/is mounted on a relatively small disk,/GOADgoes to a different disk with plenty of size. However, thecheckcommand was telling me that there wasn't enough space.After adding the modification I'm submitting wiht this PR, that error went away and I proceeded with the installation. Since the labs seem to be installed under
/GOAD/workspace/, I believe that the actual size to calculate should be.(the current directory), instead of/.Mind you, it's the first time I'm deploying GOAD; so I might be wrong and this PR probably should be rejected.
I also took the liberty of fixing the small typo there in the error message.