Reintroduce all text color utilities #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…in-his-text-colors-ic
- complete doc
Haven't tested in detail, but you might want to try the following: diff --git a/scss/_root.scss b/scss/_root.scss
index fd17dcdbd..39fa00853 100644
--- a/scss/_root.scss
+++ b/scss/_root.scss
@@ -158,6 +158,7 @@
--#{$boosted-prefix}kbd-color: #{$kbd-color-inverted};
--#{$boosted-prefix}kbd-bg: #{$kbd-bg-inverted};
--#{$boosted-prefix}pre-color: #{$pre-color-inverted};
+ --#{$prefix}body-color: #{$body-color-dark};
// stylelint-disable-next-line scss/selector-no-redundant-nesting-selector
[class*="bg-"]:not(&):not(.bg-transparent) {
@@ -175,6 +176,7 @@
--#{$boosted-prefix}kbd-color: #{$kbd-color};
--#{$boosted-prefix}kbd-bg: #{$kbd-bg};
--#{$boosted-prefix}pre-color: #{$pre-color};
+ --#{$prefix}body-color: #{$body-color};
}
}
// End modPlus, for example, adding the definition for And we will probably be able to completely remove dark variants handling in this |
- change doc on colors (text-primary now turns to the right orange on dark-bg - again) - fix pbs on dark variants by changing color of body-color and heading-color on dark-bg - fix pb on buttons no-outline btn-inverse on hover - fix pb on navbar titles on hover - fix pbs on tag dark variants - change doc on spinners (use no class on light and text-white and no - adapt backgrounds and text colors in utilities
|
@julien-deramond
Remaining pbs & questions;
|
- cards: move text-bg-** to card-body - fix wording in docs (belong to) - colored-links in helpers and utilities: restore all the links colors, add bg-dark when needed, add design callout, restore accessibility tip - maps: remove light not needed (already in theme colors)
louismaximepiton
requested changes
Jun 5, 2023
- use theme-colors.yml to add bg-dark when needed on texts and links in utilities - fix and enhance wordings in docs - forgotten bg-dark with text-white - add more icons colors combinations examples
9 tasks
9 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
Closed
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jul 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Description
Reintroduce all text color utilities to conform to Bootstrap (and in particular within the dark mode) and allow developers to use text colors when needed, for SVG icons for example.
Add a design callout to explain it to developers and draw their attention to design specifications and accessibility requirements.
Motivation & Context
In the icons documentation, it is said to use text colors but they didn't exist anymore.
Types of change
Live previews
Fix wording:
do not belong the Orange Design System specifications=>do not belong to the Orange Design System specificationsDoc, SCSS and examples (classes) changes:
Code of examples (markup or classes) changes, but doc and examples display remain exactly the same:
text-whiteextra class when needed to comply with design and accessibility requirementstext-bg-**to card body instead of the entire card to keep header black with white fonttext-whitewhen needed and no class otherwise to have the right colorSCSS changes, but doc and examples remain exactly the same:
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge