Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Form controls #2280

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 4, 2023

Description

Update star rating visual check

Form range in dark mode, by using existing Sass vars :

Sass var Previous value New value
$input-bg $white var(--#{$prefix}body-bg)
$input-disabled-color $gray-700 var(--#{$prefix}placeholder-color)
$input-color $black var(--#{$prefix}body-color)
$input-placeholder-color var(--#{$prefix}secondary-color) var(--#{$prefix}placeholder-color)

⚠️ New CSS var:

CSS var Light mode value Dark mode value
--bs-placeholder-color #666666 #999999

It could maybe be replaced by --bs-tertiary-color or --bs-secondary-color if we don't use it elsewhere.

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 4, 2023
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit e653baa
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/651e8de412c7ee000791e6e4
😎 Deploy Preview https://deploy-preview-2280--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-lmp-form-control-dark branch from fb9725b to e653baa Compare October 5, 2023 10:20
@julien-deramond julien-deramond merged commit 79c489f into main-jd-dark-mode Oct 5, 2023
@julien-deramond julien-deramond deleted the main-lmp-form-control-dark branch October 5, 2023 10:22
@julien-deramond julien-deramond mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants