Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Boosted guidelines image #2559

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented May 16, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Replace Boosted guidelines images with updated images (small and @2x)

Motivation & Context

This image does not longer represent the look of Boosted components since the last changes (in particular in colors)

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

Copy link

netlify bot commented May 16, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit ebc282d
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/664603ce848d6a0009b123fb
😎 Deploy Preview https://deploy-preview-2559--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hannahiss hannahiss marked this pull request as ready for review May 16, 2024 12:43
This reverts commit 6702acb.
@julien-deramond julien-deramond self-requested a review May 16, 2024 12:54
@hannahiss hannahiss requested a review from julien-deramond May 16, 2024 13:02
@julien-deramond julien-deramond merged commit d0f325a into main May 16, 2024
15 checks passed
@julien-deramond julien-deramond deleted the main-his-guidlines-img branch May 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants