Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(a11y): drop focusable='false' for SVGs #2678

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Aug 5, 2024

Related issues

Closes #2677

Description

This PR drops focusable="false" for SVGs since we don't support Internet Explorer anymore.

Types of change

  • Accessibility enhancement (non-breaking change)

Live previews

@julien-deramond julien-deramond added 👂 accessibility 📖 documentation Improvements or additions to documentation v5 labels Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 08e1207
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66b0a3c64551310008715ede
😎 Deploy Preview https://deploy-preview-2678--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review August 5, 2024 09:11
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't support IE and that Edge implements tabindex since quite a long time, I'd remove all the focusable occurrences and if really needed we could add tabindex="0" but I don't think it's necessary.
The remaining looks good to me.

@julien-deramond julien-deramond force-pushed the main-jd-drop-focusable-false branch from 129a79c to 08e1207 Compare August 5, 2024 10:04
@julien-deramond julien-deramond changed the title docs(a11y): drop focusable='false' for decorative SVGs docs(a11y): drop focusable='false' for SVGs Aug 5, 2024
@julien-deramond julien-deramond merged commit 1ae5c02 into main Aug 5, 2024
12 checks passed
@julien-deramond julien-deramond deleted the main-jd-drop-focusable-false branch August 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👂 accessibility 📖 documentation Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

Get rid of focusable="false" for decorative <svg>s
3 participants