chore(merge main):patched commit → 90acd33 #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
louismaximepiton
commented
Mar 4, 2025
louismaximepiton
commented
- twbs/bootstrap@b7f3d6a
- twbs/bootstrap@c5be828
- twbs/bootstrap@0f13e1c
- twbs/bootstrap@669079d
- twbs/bootstrap@90acd33
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vprothais
approved these changes
Mar 4, 2025
| @@ -932,7 +932,7 @@ Boosted's modal class exposes a few events for hooking into modal functionality. | |||
| | Event | Description | | |||
| | --- | --- | | |||
| | `hidden.bs.modal` | This event is fired when the modal has finished being hidden from the user (will wait for CSS transitions to complete). | | |||
| | `hide.bs.modal` | This event is fired immediately when the `hide` instance method has been called. | | |||
| | `hide.bs.modal` | This event is fired immediately when the `hide` instance method has been called. Can be prevented by calling `event.preventDefault()`. See [JavaScript events documentation]({{< docsref "/getting-started/javascript#events" >}}) for more details on event prevention. | | |||
There was a problem hiding this comment.
is there a reason why we don't have the same order than Bootstrap here ? (hide is before hidden on bootstrap's side)
There was a problem hiding this comment.
Good catch, I don't know tbh, I'll change it.
There was a problem hiding this comment.
Ah, I think it's for alphabetical order. Tell me if I should revert or not 317310b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.