Feature/search improvement #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app.py: * imports Add request, redirect, url_for from flask library to support query parameter usage and redirecting from the root page to the license page. * / Change behavior of root to redirect to license page. * /license Add get for parameter, then check if the parameter was passed and load the page if so. If not, load the default HTML. * /badge Same changes as license. * /name Same changes as license. This change is adding the ability for users to use query parameters if they want. Next commit will be to update the HTML to utilize these new changes.
Copy/paste doh. Change the license Flask app to use the license_lookup function instead of the badge_lookup function.
This commit cuts over the website from the URL parsing format to utilize query parameters. app.py: * LICENSE_CONTEXT Add query_param to render HTML form properly. Change lookup_url to redirect back to the same url. * BADGE_CONTEXT Same changes as LICENSE_CONTEXT * NAME_CONTEXT Same changes as LICENSE_CONTEXT. index.html: Changing root form to be explicitly a license form. Change form actions to execute GET request with query parameters as defined in the various context dicts. Remove jquery stuff because it isn't needed anymore.
Simplifying the HTML rendering for the Flask app. This removes some redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Two main commits here, one to enable query params, second to cut the HTML code over to make use of them.