Bugfix: Search on multiple fields #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing an issue where a value would be sent as None and fail the search
barrytam20
approved these changes
Feb 25, 2021
mpuckett159
approved these changes
Feb 26, 2021
src/api.py
Outdated
Comment on lines
46
to
47
| if value is None: | ||
| continue |
There was a problem hiding this comment.
Oh thanks for commenting on this specific line because I just realized it was pasted weird and the indentation is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two separate users report that last name searching was effectively broken. We found that the frontend was querying the API with empty form fields as
None(e.g. a search on first name would addlast_name=Noneto the query params). While this worked for first name searches, for some reason it failed on last name searches. This PR addresses the issue by skipping anyNonefields when composing the query params.It also adds an additional warning for the user on badge fuzzy searching, which was already present in the UI. We should try to add some mechanism for badge to be searched through the fuzzy endpoint, even if it's a strict search under the hood - we get that complaint a lot.