Default strict search to true if only strict fields are searched #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I just tried this out and it works great! Although, it doesn't alter the state of the strict search checkbox. Do you think it would be a good idea to change name_lookup to return both the HTML and strict_search so that could be supplied to the rendered HTML for further lookups?
AetherUnbound
approved these changes
Jun 12, 2021
src/dataset.py
Outdated
Comment on lines
43
to
46
| entities: typing.List[api_types.Entity], | ||
| strict_search: bool = None, | ||
| **kwargs, | ||
| ) -> str: | ||
| ) -> typing.Tuple[str, bool]: |
There was a problem hiding this comment.
Not important now, but just as a note for the future - I typically do from typing import <stuff> for the typing library to make it easier to type out 😄
AetherUnbound
deleted the
add/default-to-strict-search-if-only-strict-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is what was meant by #45 but took a shot at it.
There's probably a better way of making sure that
entitiesis only retrieved one time than what I went with 🤔