Turn the historical view into a table #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/views/officer-table.j2
Outdated
| @@ -0,0 +1,29 @@ | |||
| <table> | |||
| <thead> | |||
There was a problem hiding this comment.
Do you mind using 4 spaces for this file instead of tab characters? 😅
There was a problem hiding this comment.
Whoops! Done in fb8e213
src/views/officer-table.j2
Outdated
| {% if value and value.startswith("http") %} | ||
| <a href="{{ value }}" target="_blank" rel="noopener noreferrer">{{ value }}</a> | ||
| {% else %} | ||
| {{ value if value }} |
There was a problem hiding this comment.
Since you're casting this to string on line 18, can this just be {{ value}}?
There was a problem hiding this comment.
I'm not sure! I copied that part from officer.j2 😅 Presumably it would just be an empty string if falsy, right?
There was a problem hiding this comment.
Removed this check in feb04b2
There was a problem hiding this comment.
Oh jeez 😂 it can probably be changed there too. And yea! Should be an empty string at this point
Co-authored-by: Madison Swain-Bowden <[email protected]>
Co-authored-by: Madison Swain-Bowden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also highlights the differences between row values 🙂