New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path generation is case sensitive and it potentially generates path that are actually the same path #8742

Closed

AndreaPiovanelli opened this issue Dec 18, 2023 · 0 comments

Milestone

Contributor

AndreaPiovanelli commented Dec 18, 2023

https://github.com/OrchardCMS/Orchard/blob/9644ceda1f9b077d44aaa4ffaab103c19a59ddba/src/Orchard.Web/Modules/Orchard.Autoroute/Services/AutorouteService.cs#L243C25-L243C25

AutorouteService.GetSimilarPaths loads up all the DisplayAlias strings that start with provided path. After that, a unique slug is generated (https://github.com/OrchardCMS/Orchard/blob/9644ceda1f9b077d44aaa4ffaab103c19a59ddba/src/Orchard.Web/Modules/Orchard.Autoroute/Services/AutorouteService.cs#L188C25-L188C25) but the IEnumerable.Contains(string) function used to check if the path doesn't exist yet is case sensistive. This causes the creation of conflicting aliases (i.e. a "/TEST-PAGE" alias can be created even if a "/test-page" alias already exists in the tenant).

AndreaPiovanelli mentioned this issue

Similar paths are now compared ignoring casing #8743

Merged

sebastienros added this to the 1.10.x milestone

MatteoPiovanelli closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment