Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar paths are now compared ignoring casing #8743

Merged

Conversation

AndreaPiovanelli
Copy link
Contributor

Reference issue: #8742
Added StringComparer and forced lowercase where needed to ensure matching paths to ignore casing.
This changes apply to new content or when autoroute is changed. This means that, for existing content, if user does not change the current url textbox, the path generation is skipped, thus keeping ambiguous paths if present.
For this reason I opened a draft pull request for the moment, to find a way to avoid this ambiguity for existing content. This can be solved mainly in two ways:

  1. Forcing the slug / url generation even if the matching between url and content routevaluedictionary is passed ( )
  2. Adding a migration step (in Orchard.Autoroute or Orchard.Alias) forcing the regeneration of all ambiguous urls.

@MatteoPiovanelli
Copy link
Contributor

@sebastienros @AndreaPiovanelliLaser should we merge this in, and worry about possible pre-existing path conflicts some other time, since this should prevent any new ones from cropping up?

@sebastienros
Copy link
Member

I think you can merge, I approved the PR

@AndreaPiovanelli AndreaPiovanelli marked this pull request as ready for review January 19, 2024 08:05
@MatteoPiovanelli MatteoPiovanelli merged commit d943fbd into OrchardCMS:1.10.x Jan 19, 2024
2 checks passed
@AndreaPiovanelli AndreaPiovanelli deleted the 8742_autorouteduplicates branch June 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants