Similar paths are now compared ignoring casing #8743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #8742
Added StringComparer and forced lowercase where needed to ensure matching paths to ignore casing.
This changes apply to new content or when autoroute is changed. This means that, for existing content, if user does not change the current url textbox, the path generation is skipped, thus keeping ambiguous paths if present.
For this reason I opened a draft pull request for the moment, to find a way to avoid this ambiguity for existing content. This can be solved mainly in two ways:
Orchard/src/Orchard.Web/Modules/Orchard.Autoroute/Services/AutorouteService.cs
Line 217 in 9644ced