Balancer strategy review #1714
Closed
Balancer strategy review #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing licensing getPoolAssets gas optimized
Fixed Slither
Addresses to use checksum format
…Protocol/origin-dollar into nicka/balancer-sfrxETH-stETH-rETH
Added toPoolAsset override
Gas optimization of InitializableAbstractStrategy
* Refactor base strategy to use immutables * Fixed strategy deployments in 001_core and fixtures * Generated new strategy diagrams
Added rETH conversion to ETH value
|
Closing as replaced by #1726 |
sparrowDom
reviewed
Jul 31, 2023
| @@ -0,0 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| interface IRETH { | ||
| function getEthValue(uint256 _rethAmount) external view returns (uint256); | ||
|
|
||
| function getRethValue(uint256 _ethAmount) external view returns (uint256); |
There was a problem hiding this comment.
nitpick: could also just leave above 2 functions defined and import an IERC20 for all others
There was a problem hiding this comment.
I added the ERC20 functions as I was using rETH in Hardhat tests that called getEthValue and ERC20 functions like balanceOf.
| uint256 assetIndex = 0; | ||
| for (uint256 i = 0; i < tokensLength; ++i) { | ||
| for (uint256 i = 0; i < tokens.length; ++i) { |
There was a problem hiding this comment.
Oh I guess fetching length of memory arrays shouldn't cost much if any gas?
There was a problem hiding this comment.
tokens is in memory rather than storage here so we don't need to use an extra variable
| if (_asset == stETH) { | ||
| IERC20(stETH).approve(wstETH, 1e50); | ||
| // if frxEth | ||
| IERC20(stETH).safeApprove(wstETH, 1e50); |
| bptBalance, | ||
| address(this) | ||
| ); | ||
| require(bptBalance == auraLp, "Aura LP != BPT"); |
| IERC20 rewardToken = IERC20(rewardTokenAddresses[i]); | ||
| uint256 balance = rewardToken.balanceOf(address(this)); | ||
| address harvesterAddr = harvesterAddress; |
There was a problem hiding this comment.
does this save 1 storage read?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.