Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generalised pool tilt functionality #1849

Merged
merged 19 commits into from
Oct 20, 2023
Merged

Add generalised pool tilt functionality #1849

merged 19 commits into from
Oct 20, 2023

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Oct 3, 2023 •
edited
Loading

  • add generalized framework to tilt/untilt pools (Balancer supported now, could support Curve in the future)
  • add MEV tests for Composable stable pool

@rafaelugolini rafaelugolini temporarily deployed to preview-oeth-sparrowdom-ppeddz October 3, 2023 12:50 Inactive
@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-sparrowdom-dhbdtr October 3, 2023 12:50 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-dhbdtr October 3, 2023 20:35 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-ppeddz October 3, 2023 20:35 Inactive
@sparrowDom sparrowDom mentioned this pull request Oct 3, 2023
Closed
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-dhbdtr October 3, 2023 20:50 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-ppeddz October 3, 2023 20:50 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-oeth-sparrowdom-ppeddz October 5, 2023 09:51 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-dhbdtr October 5, 2023 09:51 Inactive
shahthepro
shahthepro reviewed Oct 12, 2023
View reviewed changes
contracts/test/fixture/_pool_tilt.js Outdated Show resolved Hide resolved
contracts/test/fixture/_pool_tilt.js Outdated Show resolved Hide resolved
contracts/test/fixture/_pool_tilt.js Outdated Show resolved Hide resolved
shahthepro
shahthepro reviewed Oct 12, 2023
View reviewed changes
contracts/test/fixture/_pools.js Show resolved Hide resolved
contracts/test/fixture/_pools.js Outdated Show resolved Hide resolved
@sparrowDom
Copy link
Member Author

Thanks a lot for CR @shahthepro

@sparrowDom sparrowDom force-pushed the sparrowDom/tilt_fixtures branch from c087d6e to b81bd7a Compare October 19, 2023 21:57
@sparrowDom sparrowDom merged commit fd5c36b into sparrowDom/balancer-composable-st-pool Oct 20, 2023
@sparrowDom sparrowDom deleted the sparrowDom/tilt_fixtures branch October 20, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahthepro shahthepro shahthepro approved these changes

@naddison36 naddison36 naddison36 approved these changes

@DanielVF DanielVF Awaiting requested review from DanielVF DanielVF is a code owner

@smitch88 smitch88 Awaiting requested review from smitch88

@rafaelugolini rafaelugolini Awaiting requested review from rafaelugolini rafaelugolini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sparrowDom @naddison36 @shahthepro @rafaelugolini