N-04 Unused Code #1922
Merged
N-04 Unused Code #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36,
shahthepro,
smitch88 and
rafaelugolini
as code owners
sparrowDom
changed the base branch from
master
to
sparrowDom/N-03-nameing-suggestions
DanielVF
approved these changes
Nov 8, 2023
Base automatically changed from
sparrowDom/N-03-nameing-suggestions
to
sparrowDom/balancer-composable-st-pool
November 8, 2023 20:36
…/N-04-unused-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ComposablePoolExitKindis now used in #1916 and for that reason shouldn't be removedAudit note:
Throughout the codebase, there are several instances of unused code:
unused.
unused.
Consider reviewing each of these instances and updating or removing them in order to improve
the clarity of the codebase.