N02 addendum #1949
Merged
N02 addendum #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36,
shahthepro,
smitch88 and
rafaelugolini
as code owners
rafaelugolini
temporarily deployed
to
preview-ousd-sparrowdom-ggsty1
sparrowDom
changed the base branch from
master
to
sparrowDom/balancer-composable-st-pool
shahthepro
approved these changes
Jan 16, 2024
pandadefi
approved these changes
Jan 17, 2024
sparrowDom
merged commit 8b94037
into
sparrowDom/balancer-composable-st-pool
9 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
safeApprovewhen approving assets instead ofapproveas a defensive programming measure in case we ever support a strategy with USDT that would cause approves to revert (since it is not ERC20 compliant -> not returning a value on approve)