Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 004 sonic update delay #2362

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jan 23, 2025

Overview

Calls updateDelay on Sonic Timelock and sets it to 1 day (86400 seconds)

Schedule Batch

{
  "version": "1.0",
  "chainId": "146",
  "createdAt": 1737667104,
  "meta": {
    "name": "Transaction Batch",
    "description": "",
    "txBuilderVersion": "1.16.1",
    "createdFromSafeAddress": "0xbe2AB3d3d8F6a32b96414ebbd865dBD276d3d899",
    "createdFromOwnerAddress": ""
  },
  "transactions": [
    {
      "to": "0x31a91336414d3B955E494E7d485a6B06b55FC8fB",
      "value": "0",
      "data": null,
      "contractMethod": {
        "inputs": [
          {
            "type": "address[]",
            "name": "targets"
          },
          {
            "type": "uint256[]",
            "name": "values"
          },
          {
            "type": "bytes[]",
            "name": "payloads"
          },
          {
            "type": "bytes32",
            "name": "predecessor"
          },
          {
            "type": "bytes32",
            "name": "salt"
          },
          {
            "type": "uint256",
            "name": "delay"
          }
        ],
        "name": "scheduleBatch",
        "payable": false
      },
      "contractInputsValues": {
        "targets": "[\"0x31a91336414d3B955E494E7d485a6B06b55FC8fB\"]",
        "values": "[\"0\"]",
        "payloads": "[\"0x64d623530000000000000000000000000000000000000000000000000000000000015180\"]",
        "predecessor": "0x0000000000000000000000000000000000000000000000000000000000000000",
        "salt": "0x69032df8400036567baf946ec6803adbe2f70e7435fedaed4793bea318a063ad",
        "delay": "60"
      }
    }
  ]
}

Execute Batch

{
  "version": "1.0",
  "chainId": "146",
  "createdAt": 1737667104,
  "meta": {
    "name": "Transaction Batch",
    "description": "",
    "txBuilderVersion": "1.16.1",
    "createdFromSafeAddress": "0xbe2AB3d3d8F6a32b96414ebbd865dBD276d3d899",
    "createdFromOwnerAddress": ""
  },
  "transactions": [
    {
      "to": "0x31a91336414d3B955E494E7d485a6B06b55FC8fB",
      "value": "0",
      "data": null,
      "contractMethod": {
        "inputs": [
          {
            "type": "address[]",
            "name": "targets"
          },
          {
            "type": "uint256[]",
            "name": "values"
          },
          {
            "type": "bytes[]",
            "name": "payloads"
          },
          {
            "type": "bytes32",
            "name": "predecessor"
          },
          {
            "type": "bytes32",
            "name": "salt"
          }
        ],
        "name": "executeBatch",
        "payable": true
      },
      "contractInputsValues": {
        "targets": "[\"0x31a91336414d3B955E494E7d485a6B06b55FC8fB\"]",
        "values": "[\"0\"]",
        "payloads": "[\"0x64d623530000000000000000000000000000000000000000000000000000000000015180\"]",
        "predecessor": "0x0000000000000000000000000000000000000000000000000000000000000000",
        "salt": "0x69032df8400036567baf946ec6803adbe2f70e7435fedaed4793bea318a063ad"
      }
    }
  ]
}

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.94%. Comparing base (097f3f3) to head (d77c859).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2362   +/-   ##
=======================================
  Coverage   51.94%   51.94%           
=======================================
  Files          91       91           
  Lines        4414     4414           
  Branches     1162     1162           
=======================================
  Hits         2293     2293           
  Misses       2118     2118           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparrowDom sparrowDom merged commit 1817476 into master Jan 27, 2025
14 of 20 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/deploy_004_sonic branch January 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants