Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Consistent Event Notifications, Properly Documented #810

Closed
micahalcorn opened this issue Oct 24, 2018 · 2 comments
Closed

Consistent Event Notifications, Properly Documented #810

micahalcorn opened this issue Oct 24, 2018 · 2 comments
Assignees
@franckc
Labels
dapp docs good first issue Good for newcomers help wanted Extra attention is needed javascript notifications origin.js ui/ux

Comments

@micahalcorn
Copy link
Member

micahalcorn commented Oct 24, 2018 •
edited
Loading

This isn't quite accurate. I believe that on-demand, derived notifications only include offerCreated, offerFinalized, and offerAccepted. We should expand them to include all offer-related events, including rejection/withdrawal, arbitration-related, etc. Let's also ensure that push notifications are consistent as well and then document all of it.
This was referenced Oct 24, 2018
Merged
Closed
@micahalcorn
Copy link
Member Author

I started to work on this, but getNotifications relies on getListing, which excludes withdrawn/rejected offers. I'm not sure what consequences there would be to changing that behavior, so I'll leave this for now.

@franckc franckc self-assigned this Nov 28, 2018
@franckc franckc mentioned this issue Dec 2, 2018
Merged
4 tasks
@micahalcorn
Copy link
Member Author

Resolved by #1025 ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@franckc franckc

Labels
dapp docs good first issue Good for newcomers help wanted Extra attention is needed javascript notifications origin.js ui/ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micahalcorn @franckc