-
Notifications
You must be signed in to change notification settings - Fork 195
Conversation
@@ -643,15 +659,24 @@ export default class Marketplace { | |||
}) | |||
) | |||
} catch(e) { | |||
// TBD: what exactly are we guarding against here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. Makes sense - we want to protect against invalid offers.
Will add comment.
Will also add checks in other places of the notification code to harden it further: when fetching listing in this method, and also at the adapter level in the getNotification method (for ex an invalid IPFS Hash could cause that layer to error out).
…o franck/dapp_notification_cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nothing stands out as an issue, though I'm not super familiar with this part of the code
First pull request? Read our guide to contributing
Description:
This covers DApp fixes for #810 - fixes to the notification server will be handled as a separate PR.
Checklist: