Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Cleanup DApp notifications #1025

Merged
merged 10 commits into from
Dec 3, 2018
Merged

Cleanup DApp notifications #1025

merged 10 commits into from
Dec 3, 2018

Conversation

franckc
Copy link
Contributor

@franckc franckc commented Nov 30, 2018

First pull request? Read our guide to contributing

Description:

This covers DApp fixes for #810 - fixes to the notification server will be handled as a separate PR.

  • Updated notification logic to include all offer statuses and to filter out notification based on party that initiated the action.
  • Added unit test to cover new notification types
  • Tweaked a bit code in marketplace tests to make it more explicit what account was being used.
  • Cleaned up Notification model
  • Updated origin-js doc

Checklist:

  • Test your work and double-check to confirm that you didn't break anything
  • Wrap any new text/strings for translation
  • Map any new environment variables with a default value in the Webpack config
  • Update any relevant READMEs and docs

@micahalcorn micahalcorn self-requested a review November 30, 2018 06:49
@@ -643,15 +659,24 @@ export default class Marketplace {
})
)
} catch(e) {
// TBD: what exactly are we guarding against here ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franckc see this and probably this can be closed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Makes sense - we want to protect against invalid offers.
Will add comment.

Will also add checks in other places of the notification code to harden it further: when fetching listing in this method, and also at the adapter level in the getNotification method (for ex an invalid IPFS Hash could cause that layer to error out).

@franckc franckc changed the title [WIP] Cleanup DApp notifications Cleanup DApp notifications Dec 3, 2018
@franckc franckc requested a review from nick December 3, 2018 04:53
Franck Chastagnol added 2 commits December 2, 2018 21:00
Copy link
Contributor

@nick nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nothing stands out as an issue, though I'm not super familiar with this part of the code

@franckc franckc merged commit 8988de5 into master Dec 3, 2018
@franckc franckc deleted the franck/dapp_notification_cleanup branch December 3, 2018 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants