Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of DENY access #235

Closed
fmigneault opened this issue Nov 13, 2019 · 2 comments · Fixed by #353
Closed

Support of DENY access #235

fmigneault opened this issue Nov 13, 2019 · 2 comments · Fixed by #353
Assignees
Labels
feature New feature to be developed investigate Issue or new component that needs further exploration
Milestone

Comments

@fmigneault
Copy link
Collaborator

fmigneault commented Nov 13, 2019

Feature

Consider the possibility to support the option to add an non-permission that would restrict the user access to a resource.
General use case:

                            deny        allowed
service                                    X
├─ resource1               
│    ├─ resource2             X   
│    │    ├─ resource2.1  
│    │    └─ resource2.2                   X 
│    └─ resource3 
└─ resource4

Allowed user/group access: service, resource1, resource3, resource4
Denied user/group access: resource2, resource2.1, resource2.2 (deny has priority)

Changes

  • This feature would need to refactor UI to have Allow|Deny|None instead of simple checkboxes.
  • It would also require a new field during POST request to specify whether the created permission is Allow|Deny.
  • Parsing of permissions would need to continue all the way to the top service to check for denial access in case lower allowed was given (current behaviour is to exit with allowed access directly).
@fmigneault fmigneault added feature New feature to be developed investigate Issue or new component that needs further exploration labels Nov 13, 2019
@dbyrns
Copy link
Contributor

dbyrns commented Nov 13, 2019

@tlvu and @huard this is what we should check to support the special case grant access to everything but that private folder.
The current implementation which is way simpler still support the case where we forbid access to everything but the public folder (where everything could be added except the private data). So in short if we can organize the data a little bit we could avoid this complex issue completely.
So I would like to have your opinion on that.

@tlvu
Copy link
Contributor

tlvu commented Nov 13, 2019

As @fmigneault described in comment Ouranosinc/pavics-sdi#111 (comment), this issue is to implement option 3.

Not sure how thredds layout will evolve in the future but if changes are infrequent, I guess we can go with option 2 so at least browsing is working for top-level and delay this major refactoring until it's really needed.

Just my opinion, don't know what @huard think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature to be developed investigate Issue or new component that needs further exploration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants