Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdba Adjust methods work in adjust function #480

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Oct 24, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • dtrain in adjust is optional, you can instead pass a method str, to use a biasadjust method that only uses adjust

Does this PR introduce a breaking change?

Not for now. If we would like a more natural ordering or arguments in the adjust signature, then we would need some breaking changes (for now I've put the new arguments at the very end of the signature)

Other information:

  • group needs to be passed in xclim_adjust_args when using this method. It can be the unparsed group. Is there a problem with this way of doing this? IMO, this is better than having to explicitly pass group to the function.
    I my YAML scripts, I directly put the group in xclim_train_args, and I know that those kwargs must be parsed at some point, e.g. because group comes from a YAML, is not yet a Grouper.

@coxipi coxipi changed the title sdba's Adjust methods work in xscen's adjust function sdba Adjust methods work in adjust function Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants