Address warnings #516
Merged
Address warnings #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
reviewed
Jan 22, 2025
RondeauG
reviewed
Jan 22, 2025
Co-authored-by: Pascal Bourgault <[email protected]>
for more information, see https://pre-commit.ci
|
Warnings are now below 800 in total, with the majority (600+) stemming from |
RondeauG
approved these changes
Jan 22, 2025
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
xscen.adjust(RankWarning: Polyfit may be poorly conditioned)Does this PR introduce a breaking change?
No.
Other information:
Many warnings are coming from deprecated usages in
intake-esm. It would be worthwhile to see what can be done to address them from there.