Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix skin files path #559

Merged
merged 2 commits into from
Jan 13, 2025
Merged

config: fix skin files path #559

merged 2 commits into from
Jan 13, 2025

Conversation

dalamudx
Copy link

@dalamudx dalamudx commented Jan 8, 2025

image

@cactbotbot
Copy link
Collaborator

cactbotbot commented Jan 8, 2025

@dalamudx Thanks for your contribution! 🌵🚀

@github-actions github-actions bot added resources /resources needs-review Awaiting review labels Jan 8, 2025
@dalamudx dalamudx changed the title fix skin files path config: fix skin files path Jan 8, 2025
@xiashtra
Copy link
Collaborator

xiashtra commented Jan 11, 2025

Can you provide some more information regarding the problem you are trying to solve here? I cannot replicate the error you are seeing with the following basic user override file (name as raidboss.js, place in your cactbot/user directory):

Options.Skin = 'dorgrin';

@dalamudx
Copy link
Author

when you open https://overlayplugin.github.io/cactbot/ui/config/config.html?OVERLAY_WS=ws://x.x.x.x:xxxx/ws,
and change the raidboss skin to dorgrin or others,then reload the page,the error will occur
image

@dalamudx
Copy link
Author

After compilation,the related file is ui/config/config.bundle.js,upon review the source code,should fix the resources/user_config.ts.

Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify the issue here (as there appears to be a language barrier):

The skins path in user_config.ts assumes that it's relative to raidboss.html, but config.html also uses this path.

This PR adjusts the path so it should work with both HTML files.

@github-actions github-actions bot removed the needs-review Awaiting review label Jan 12, 2025
@xiashtra xiashtra merged commit 8d1ddc6 into OverlayPlugin:main Jan 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resources /resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants