Added global types to GameBoard, Map and autoloads #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used ctrl+shift+R for all changes here, overall it did not take much time. Did exactly 3 things here: 1. Replaced all `preload` with `load`. 2. Changed most (maybe all?) autoload singleton calls to their static versions. This step required a bit of attention in `Settings` and `MouseLayer` singletons due to similarly named variables. Also had to fix some self.map.X calls that were used to access these singletons. 3. Changed some classes used by Map and Gameboard to global classes and added direct reference to Map/Gameboard class.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used ctrl+shift+R for all changes here, overall it did not take much time. Did exactly 3 things here:
preloadwithload.SettingsandMouseLayersingletons due to similarly named variables. Also had to fix some self.map.X calls that were used to access these singletons.(Plus, i also disabled type warnings for now, since they create a lot of messages)
Game launches without any problems.