Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV/TSV Viewer; shortcut links on feature view #1004

Merged
merged 69 commits into from
Dec 8, 2020

Conversation

DinaBai
Copy link
Contributor

@DinaBai DinaBai commented Oct 27, 2020

Requesting alpha testing of tsv/csv table viewer.

DinaBai added 30 commits May 15, 2020 14:44
…ore. Hard coded columns (may change this later). Work in progress
…n row numbers to the table to make multi-select work. Adding Features button.
…oes not work and probably is not viable because for the tsv/csv table, we need to filter the store.
…n example of client side filtering of the store. This doesn't work. The store appears to be filtered but the table is not refreshed.
…instead of hard coding them. Doing this before I fill in the column options for filtering.
…boxes are added to the grid on the left side.
…that do not have features. Work in Progress.
…even when tables are viewed one after another. I think it cooperates better with ActionBar. It was hard to keep the disabled/enabled buttons up to date.
…ader. It doesn't work without the TSV in the typeslist (found in Workspace). Also, files are not sent to the TsvCsvViewer for display if their suffix matches any of the keys in the structure found in TsvCsvFeatures. This does work.
DinaBai and others added 13 commits October 16, 2020 16:01
…s. Did this in ActionBar.js. Left the Copy button, but it is not working correctly yet. Also, did some clean up like deleting commented code sections.
…hanged the wording of selection copy to say that rows (rather than columns) are being copied.
…en first row was selected as containing column headers. Also, fixed a bug where registry components were not being destroyed when user displayed one table immediately after another.
@nconrad nconrad changed the base branch from preview to features/csv-viewer October 27, 2020 19:44
@nconrad
Copy link
Contributor

nconrad commented Oct 27, 2020

Hi @DinaBai and @aswarren, I changed the base branch to feature/csv-viewer to keep the development separate from releases. There's a lot of changes, and so I'd like to look over some of them. The linter check may have failed? I'll take a look tomorrow. thanks!

@aswarren
Copy link
Contributor

@nconrad it probably appears to be more changes because the preview branch hasn't been updated in quite some time.

@nconrad
Copy link
Contributor

nconrad commented Oct 29, 2020

@DinaBai @aswarren This is on alpha now. Looks useful. I didn't merge because of commit fe383d2 (to be safe). It may be good to have some public workspace CSV examples to share with the team?

@DinaBai
Copy link
Contributor Author

DinaBai commented Oct 29, 2020

@nconrad @aswarren Thanks for putting this on alpha. Can I create a directory in the public workspace or does this require some permission I do not yet have? I have not tried, but I will. I will create a TSV/CSV Viewer Test folder and I can add the files I used for testing. I can also add a readme.txt. It would be good if testers also tried their own files though because perhaps other files will contain info I did not anticipate.

@DinaBai
Copy link
Contributor Author

DinaBai commented Oct 29, 2020

@nconrad @aswarren New folder in the public workspace called Test_CSV_TSV_Viewer contains three test files and a short readme file. If you want me to add or change anything, let me know. Thanks for your help.

@nconrad nconrad changed the title Develop CSV/TSV Viewer Oct 30, 2020
@nconrad
Copy link
Contributor

nconrad commented Oct 30, 2020

@DinaBai This is pretty cool. This and the readme.txt helps a lot as a summary. Although I know ya'll had your discussions about why this is useful, if you are willing, this is probably one of those things that would make sense to present to the entire group on Tuesday.

I promise to stop commenting on PRs this late in evening.

@DinaBai
Copy link
Contributor Author

DinaBai commented Oct 30, 2020

@nconrad Thank you! I can present it on Tuesday if Ron agrees there is time on the agenda.

I promise to stop reading comments on this PR late in the evening, starting now...

@nconrad nconrad changed the title CSV/TSV Viewer CSV/TSV Viewer; shortcut links on feature view Dec 8, 2020
@nconrad nconrad merged commit 97c68c5 into PATRIC3:features/csv-viewer Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants