Added timeout functionality for pathway summary. Related to #2362.

[JacobPorter]

When a pathway summary query timeouts, the circular wait widget is removed, and then an alert and message is produced that says, "The query took too long or could not be loaded."

[nconrad]

@JacobPorter Can you put these slashes back in for consistency? It doesn't look like there's a trailing slash in the configs on the servers.

[JacobPorter]

The apiServer string ended with a slash, so that is why it was removed. I can put it back in if you like since it won't hurt anything, but then there will be two slashes.

[dmachi]

This depends on how it was defined in the config file. I suspect your local dev env doesn’t have the trailing slash defined as part of that api server url, but in the dev/production environments they do. So one of these things needs to happen: a) how it is defined in configs needs to be consistent between dev/production or b) there needs to be some code that normalizes what is provided in the config (to not have the slash), or c) there needs to be a joiner used to construct these paths that takes the slash into account (this will have to be modified all over the place).

…

On Jun 25, 2020, at 12:30 PM, Jacob Porter ***@***.***> wrote: @JacobPorter commented on this pull request. In public/js/p3/store/PathwaySummaryMemoryStore.js <#977 (comment)>: > @@ -173,7 +173,7 @@ define([ return p + '=' + query[p]; }).join('&'); - return when(request.post(_self.apiServer + '/pathway/', { + return when(request.post(_self.apiServer + 'pathway/', { The apiServer string ended with a slash, so that is why it was removed. I can put it back in if you like since it won't hurt anything, but then there will be two slashes. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#977 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABOQ3X4H3O533NOKVCV5ALRYN3UFANCNFSM4NVEZDYA>.

[nconrad]

@dmachi I likely sent @JacobPorter my local config that did have a trailing slash. I'm now looking at the default config https://github.com/PATRIC3/p3_web/blob/master/config.js and the dataServiceURL in window.App on prod/beta/alpha/etc:

...
accountURL: "https://user.patricbrc.org"
alreadyLoggedIn: true
api: {workspace: ƒ, service: ƒ, data: ƒ}
appLabel: ""
appServiceURL: "https://p3.theseed.org/services/app_service"
appVersion: "3.6.5"
applicationContainer: {srcNodeRef: div#ApplicationContainer.dijitBorderContainerNoGutter.dijitContainer.layoutContainer.dijitLayoutCon…, _connects: Array(0), _supportingWidgets: Array(0), id: "ApplicationContainer", params: {…}, …}
compareregionServiceURL: "https://p3.theseed.org/services/compare_regions"
dataAPI: "https://patricbrc.org/api/"
dataServiceURL: "https://patricbrc.org/api"
docsServiceURL: "https://docs.patricbrc.org/"
enableDevTools: false
gaID: "UA-11736060-7"
genomedistanceServiceURL: "https://p3.theseed.org/services/minhash_service"
homologyServiceURL: "https://p3.theseed.org/services/homology_service"
localStorageCheckInterval: "15000"
probModelSeedServiceURL: "https://p3.theseed.org/services/ProbModelSEED"
serviceAPI: "https://p3.theseed.org/services/app_service"
shockServiceURL: "https://p3.theseed.org/services/shock_api"
toaster: {_attachPoints: Array(3), _attachEvents: Array(1), srcNodeRef: null, _connects: Array(0), _supportingWidgets: Array(0), …}
userServiceURL: "https://user.patricbrc.org"
version: "3.0"
workspaceAPI: "https://p3.theseed.org/services/Workspace"
workspaceServiceURL: "https://p3.theseed.org/services/Workspace"
...

[Note the other "dataAPI", "serviceAPI", "workspaceAPI" urls too]

I don't think the extra slash actually hurts anything? Or, there's also the PathJoin utility function somebody created.

[nconrad]

@JacobPorter thanks, and sorry for the confusion. I'm partly operating on "if it ain't broken, don't fix it" for a couple weeks, and maybe we'll have maintenance time to address some of these issues.