Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision #71

Merged
merged 12 commits into from
Aug 19, 2024
Merged

Revision #71

merged 12 commits into from
Aug 19, 2024

Conversation

3gf8jv4dv
Copy link
Contributor

No description provided.

@3gf8jv4dv 3gf8jv4dv marked this pull request as ready for review August 16, 2024 21:46
Deep-Dark-Forest
Deep-Dark-Forest requested changes Aug 17, 2024
View reviewed changes
ABOUT.md Show resolved Hide resolved
hejiehao
hejiehao reviewed Aug 17, 2024
View reviewed changes
ABOUT.md Outdated Show resolved Hide resolved
Deep-Dark-Forest
Deep-Dark-Forest requested changes Aug 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
WForst-Breeze
WForst-Breeze requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@WForst-Breeze WForst-Breeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其它观点同其它 review

README.md Outdated Show resolved Hide resolved
@WForst-Breeze WForst-Breeze added ★ 表格内容 补充、更新、调整、完善表格正文内容 ◈ 修正 该内容需要参照建议进行修正 labels Aug 17, 2024
wuliaodexiaoluo
wuliaodexiaoluo requested changes Aug 17, 2024
View reviewed changes
ABOUT.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@wuliaodexiaoluo
Copy link
Member

启动 Minecrat 1.7.10-1.12.2 游戏内无声音

游戏无声音

这两项要不合并到一起？

@3gf8jv4dv
Copy link
Contributor Author

这两项要不合并到一起？

These two are actually different issues, but I do not know how to modify this better.

@wuliaodexiaoluo
Copy link
Member

These two are actually different issues, but I do not know how to modify this better.

Actually, both of these problems are the same steps, first try to press F3+T to reinitialize, then check the audio configuration, and finally check the firewall.
I'll try to merge it together.

@3gf8jv4dv @hejiehao
@Deep-Dark-Forest @WForst-Breeze @wuliaodexiaoluo
Apply some suggestions
615d0ac 
Co-authored-by: 何杰豪 <[email protected]>
Co-authored-by: 深黑森林 <[email protected]>
Co-authored-by: 风释清然SC <[email protected]>
Co-authored-by: 无聊的小洛 <[email protected]>
@WForst-Breeze
Copy link
Member

WForst-Breeze commented Aug 17, 2024 •
edited
Loading

我会在合并前自己再手动将一些地方改一下的，感谢

小洛提及的内容不建议合并，因为实质上涉及的是两个问题，这样区分开会在做问题判断的时候舒服一点

hejiehao
hejiehao reviewed Aug 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@wuliaodexiaoluo @hejiehao
Update README.md
ec265f4 
Co-authored-by: 何杰豪 <[email protected]>
@WForst-Breeze WForst-Breeze added ▲ 合并 该内容完成全部审查，已经合并并更新 and removed ◈ 修正 该内容需要参照建议进行修正 labels Aug 19, 2024
@WForst-Breeze WForst-Breeze merged commit ee9671b into PCL-Community:form Aug 19, 2024
@3gf8jv4dv 3gf8jv4dv deleted the revision branch August 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hejiehao hejiehao hejiehao left review comments

@Deep-Dark-Forest Deep-Dark-Forest Deep-Dark-Forest requested changes

@wuliaodexiaoluo wuliaodexiaoluo wuliaodexiaoluo requested changes

@WForst-Breeze WForst-Breeze WForst-Breeze approved these changes

Assignees
No one assigned
Labels
▲ 合并 该内容完成全部审查，已经合并并更新 ★ 表格内容 补充、更新、调整、完善表格正文内容
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3gf8jv4dv @wuliaodexiaoluo @WForst-Breeze @hejiehao @Deep-Dark-Forest