Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing the static library #35

Closed
robertodr opened this issue Dec 15, 2016 · 1 comment
Closed

Testing the static library #35

robertodr opened this issue Dec 15, 2016 · 1 comment
Assignees
@robertodr
Labels
bug testing

Comments

@robertodr
Copy link
Member

Issue #34 shows that our CI system doesn't check if the static library libpcm.a is sane or not.
Some of the CI builds should be run with the --static options to the setup.py script.
@robertodr robertodr added the bug label Dec 15, 2016
@robertodr robertodr self-assigned this Dec 15, 2016
robertodr added a commit that referenced this issue Feb 5, 2017
@robertodr
Fix generation of faulty static library
e1d3579 
This commit fixes issues #34, #35 and #36 (on GitHub)
and #60, #61 and #62 (on GitLab)
The fix consisted in subscribing **all** subclasses to the factory in
a top-level convenience header that gets included into the `Meddle.cpp`
file.
Namespaces have finally been introduced into the project and some core
abstract base classes have been renamed to signal their ABC status.
Please see the [change log](CHANGELOG.md) for detailed information.
@robertodr
Copy link
Member Author

Closed with e1d3579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertodr robertodr

Labels
bug testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertodr