Prune small finite elements from cavity #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
robertodr
changed the title
Tesserae with area less than 1.0d-4 AU^2 are pruned from the finite elements list. These finite elements cause numerical instabilities in the formation of the S matrix.
Versioning can be computed correctly even when PCMSolver is hard-copied into another Git repository. `__is_hard_copy = True` should be added to the copy of `tools/metadata.py` for this to work correctly.
robertodr
force-pushed
the
prune-cavity
branch
from
9f87dc3 to
18285d4
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2 #178 +/- ##
===============================================
+ Coverage 72.52% 72.65% +0.12%
===============================================
Files 92 92
Lines 5668 5693 +25
===============================================
+ Hits 4111 4136 +25
Misses 1557 1557
Continue to review full report at Codecov.
|
|
@ilfreddy I am merging so I can finish up a new release. You've looked at this changes in the previous PR anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements removal of finite elements with too small area (<= 1.0d-04) These finite elements can cause the calculation of the S and D matrices to be numerically unstable. For example, the S matrix can end not being symmetric positive-definite.
I've also split the printing of the citation and set up report into two separate functions.
Types of changes
Status