Remove dependency on JIT in pcre2_compile.c

[az-airtech]

Hi,

I have a hard requirement in a project to not use JIT. While there are CMake flags available (SUPPORT_JIT) available to effectuate this by configuration, the requirement is such that we do not even want to link with pcre2_jit_compile.c.o.

This worked fine in the old PCRE2 repository of pcre2-10.36 that we used, but one necessary #ifdef SUPPORT_JIT disappeared in the current Github repository. Diff below. If there is no particular reason why this #ifdef disappeared, I would request to put it back.

diff --git a/src/pcre2_compile.c b/src/pcre2_compile.c
index d9eb7e5..3e4a44f 100644
--- a/src/pcre2_compile.c
+++ b/src/pcre2_compile.c
@@ -1266,9 +1266,10 @@ PCRE2_SIZE* ref_count;
 
 if (code != NULL)
   {
+#ifdef SUPPORT_JIT
   if (code->executable_jit != NULL)
     PRIV(jit_free)(code->executable_jit, &code->memctl);
-
+#endif
   if ((code->flags & PCRE2_DEREF_TABLES) != 0)
     {
     /* Decoded tables belong to the codes after deserialization, and they must

Arnoud.

[PhilipHazel]

I cannot see the code that you quote in the 10.36 tarball or indeed in an earlier one. Was this perhaps a local patch you made?
However, it seems a non-controversial patch; I will look in more detail in due course.

[az-airtech]

You are actually correct, I now found out. It is indeed a local patch, which I was not initially aware of. Sorry for the confusion. If you could look into it in due course and consider it non-controversial, that would be much appreciated.

…

On Fri, 17 Jun 2022 at 15:24, Philip Hazel ***@***.***> wrote: I cannot see the code that you quote in the 10.36 tarball or indeed in an earlier one. Was this perhaps a local patch you made? However, it seems a non-controversial patch; I will look in more detail in due course. — Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW5ZRR3MRXP5WCCWA7PE4GLVPQY4XANCNFSM5ZA7AY5A> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[PhilipHazel]

I have committed this patch so it will be in the next release, whenever that is.

[az-airtech]

Thank you!

…

On Thu, 30 Jun 2022 at 18:39, Philip Hazel ***@***.***> wrote: I have committed this patch so it will be in the next release, whenever that is. — Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW5ZRR3PI6QQ3RDENQCNXQTVRXES3ANCNFSM5ZA7AY5A> . You are receiving this because you authored the thread.Message ID: ***@***.***>