maint: avoid clang masquerading as gcc in ManyConfigTests #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
reviewed
Jan 13, 2025
maint/ManyConfigTests
Outdated
Comment on lines
116
to
118
| # If the compiler is GCC or Clang, add a lot of warning switches. | ||
|
|
||
| CC_VER_OUTPUT=`printf '#ifdef __GNUC__\nGCC=yes\n#endif\n' | $CC -E -` | ||
| CC_VER_OUTPUT=`printf '#if defined(__GNUC__) && !defined(__clang__)\nGCC=yes\n#endif\n' | $CC -E -` |
There was a problem hiding this comment.
It doesn't work? That's annoying, sorry.
We should fix the comment above to remove "or Clang".
There was a problem hiding this comment.
It might be broken also with Intel's (at least the legacy) compiler as well then.
__GNUC__ is defined by any compiler that claims compliance to GNU but that doesn't include the cmdline interface, so avoid passing GCC specific warning flags to clang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid confusing clang (as a system compiler in macOS or other platforms) with gcc by ManyConfigTests.