Qt: Patch macdeployqt to always deploy Qt SVG imageformat plugin #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems silly, but since we don't have a direct reference to QtSvg, it doesn't deployed directly from the main binary (only indirectly from iconengines), and the libqsvg.dylib imageformat plugin does not get deployed. Patch macdeploy to remove the Svg check, ensuring the dylib is always deployed. Fixes controller images not being displayed in Mac builds.
stenzek
changed the title
|
Confirmed to fix image on 14.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This seems silly, but since we don't have a direct reference to QtSvg, it doesn't deployed directly from the main binary (only indirectly from iconengines), and the libqsvg.dylib imageformat plugin does not get deployed.
Patch macdeploy to remove the Svg check, ensuring the dylib is always deployed.
Rationale behind Changes
Fixes controller images not being displayed in Mac builds.
Suggested Testing Steps
Check for controller images in Mac build.