Debugger: Add Saved Addresses tab widget for bookmarking memory addresses #10518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RTTI is disabled in our builds, but |
Daniel-McCarthy
force-pushed
the
Saved-Memory-Addresses
branch
3 times, most recently
from
2b50c16 to
79beee6
Compare
JordanTheToaster
approved these changes
Jan 1, 2024
RedDevilus
reviewed
Jan 3, 2024
RedDevilus
reviewed
Jan 3, 2024
Daniel-McCarthy
force-pushed
the
Saved-Memory-Addresses
branch
from
79beee6 to
b71a098
Compare
RedDevilus
approved these changes
Jan 3, 2024
Mrlinkwii
approved these changes
Jan 4, 2024
kamfretoz
approved these changes
Jan 5, 2024
stenzek
reviewed
Jan 5, 2024
Adds a tab widget to the debugger that allows saving/bookmarking memory addresses and giving them labels/descriptions for convenience. Includes the ability to jump back to memory addresses from the Saved Addresses tab, and adding Saved Addresses from memory search search results context menu and the memory view context menu. Also supports importing and exporting the saved addresses as CSV format.
…w tab Previously when double clicking a memory search result it would go to the address but not switch to the memory view tab if the user wasn't already on it. Now it ensures the user moves to the memory view widget, as this is almost always going to be the user's intention.
Adds const to variables that could use them but currently don't and replaces 256 literal uses with Qt::UserRole to be clear what it is for and how this number is used as currently it's a bit confusing.
Daniel-McCarthy
force-pushed
the
Saved-Memory-Addresses
branch
from
b71a098 to
612fc86
Compare
Yeah, I was thinking to merge this in and then will add the serialization/debugger settings as a followup. Thanks for checking 👍 |
|
All good! Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds the ability to save memory addresses to a newly added
Saved Addressestab widget in the debugger.Works as a way to bookmark memory addresses and allow jumping back to saved addresses.
Adds the ability to add memory addresses as a Saved Addresses from the Memory Search results list context menu and
Memory Viewcontext menu. Also allows exporting and importing the Saved Addresses in CSV format so that users can save/restore their addresses.Additional changes
Memory View. Previously it would change the address but stay on the same widget (thus not showing the address to the user).256as a literal in place ofQt::UserRoleto make it more clear what it's purpose is/where the number stems from.CpuWidget.cpp.Rationale behind Changes
Helps making keeping track of memory addresses/search results easier by allowing the user to give labels/descriptions and immediately jump back to that address in the
Memory VieworDisassembly View.This makes it easier to juggle between different memory addresses and remembering details about each, and being able to quickly compare different areas of memory.
Suggested Testing Steps
Saved Addressescontext menu; memory search result context menu; andMemory Viewcontext menu.Memory Viewtab takes you to theMemory Viewtab.