Sounds: Use freely licensed sound for achievement unlock #12219
Conversation
TheTechnician27
force-pushed
the
unlock
branch
from
ff3678b to
f7e19ac
Compare
|
@Blackbird88 and @nokia8801, do you have any suggestions or reasoning for your thumbs down? It's a fact that we don't have rights to the Xbox 360 achievement sound. You're free to suggest something else. |
|
Well first of all, I can thumbs down if I wish so, that's why the feature is there. Second of all, this only came to light because of my pull request that got closed, where I wanted it changed with the iconic PS3 trophy sound. #12216 But I do understand the legal stuff, though it's funny how it's smooth sailing with the Xbox 360 sound for more than 2 years and it also gets distributed with PCSX2 all this time, but suddenly it's an issue when it comes to the PS3 sound, and now the Xbox 360 sound is getting booted too. Thirdly, the proposed file is bad, imo. It's only one note. It sounds more appropriate for navigating a menu or something. An achievement unlock sound should have more than one note. Though I do understand it's free to use with the correct license. It just sounds bad to me. My opinion. I'm half tempted to recreate the PS3 sound in GarageBand. Would that be ok, legality wise? A fan recreation. Or do I need to consult a lawyer? Edit: Also, DuckStation suffers from the same issue. Might want to check that too. I just feel like it's a bit too on the nose, but I'm no dev and don't know the legal repercussions of something like this. So I understand. I myself will keep patching that file to replace it with PS3 sound when building from -git. |
The PlayStation 3 trophy unlock sound which you wanted to add has only one note. That said, this is one of those things where even if you disagree with this PR's sound effect, there needs to be a holdover until there's time to bikeshed over the sound effect (which rest assured, will be done).
No, this would not be legal to redistribute alongside PCSX2 in the same way that I couldn't redistribute a verbatim copy of the PS2 BIOS if I programmed it from the ground up. |
Never said otherwise, I just asked for your opinion.
Sorry your PR didn't get merged, but good did result from it. We realized that we were distributing audio we don't have the rights to.
I don't really understand what you're trying to say. It's not conspiracy. No one thought about it until you tried to change it.
Thanks for that, community feedback is why I asked you in the first place.
I'm sure you know the answer to that, if you want a right answer, consult a lawyer 😅. I'd guess a fan recreation, obviously not completely verbatim, without sampling any copyrighted sound wouldn't be illegal. Although we will probably just use something with clearer usage rights.
That's fine. I think most people would agree that the authentic PS3 sound would be a great addition, but we just don't have the rights to do it. |
TheTechnician27
force-pushed
the
unlock
branch
from
f7e19ac to
4055c23
Compare
|
@MarcoEstevez @nokia8801 @Blackbird88 What do you think of this new one from FreeSound.org? |
TheTechnician27
changed the title
|
Much better now |
|
Oh yeah, that's much better indeed. |
I'd prefer if it was possible to use custom sounds before the sound gets replaced. Right now updater keeps replacing any altered files. |
Agreed, giving the user the option to replace the file would be great! I add this line to the pcsx2-git AUR PKGBUILD, when compiling from source:
unlock.wav is the PS3 sound in my case. Of course, this means I'm running an unsupported build, thus I'm not allowed to report bugs I guess. But having the option to toggle on the AppImage through the GUI would be nice too. But the new proposed sound is a nice generic one, imo, so it's not too bad of a loss compared to before the change. |
|
For the time being we are going to go ahead with this sound. In the future we can support configurable sound sources. |
UPDATE: This file was changed from an orchestral sting on Wikimedia Commons to one that's more in line with other notification sounds on other gaming platforms.
Description of Changes
Changes the unlock sound effect to an orchestra hit from Wikimedia Commons and credits the new unlock sound effect to that source in the documentation.
Rationale behind Changes
Current unlock sound is mistakenly taken from RetroAchievements, which is the Xbox 360 achievement unlock sound effect and thus proprietary and licensed to the Microsoft Corporation. This one is under the GNU Free Documentation License 1.2 as well as CC BY-SA 3.0. This PR satisfies the former, as PCSX2 is distributed under the GPLv3 license.
Suggested Testing Steps
CommonsFreeSound.org) and listen to the sound effect, making sure it's suitably "achievement-sounding". I personally like it, but if nothing else, this can be a holdover, since the current sound effect no matter what cannot be distributed with PCSX2.