Fix PS command #192
Open
Fix PS command #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As shown by the tests, this will break Probably a configuration option? I don't really feel we can split codebase into two separate versions, as that would introduce more problems than solve (since there is no way of detecting which |
|
I think providing something like a |
pshenmic
added a commit
to dashpay/docker-compose
that referenced
this pull request
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using docker-compose, it always skips the first container (because indexes are zero based).
The other commit is that
docker-compose(at least v2.0.1) also sends the name of the container and the service name, which the current parser doesn't account for.