Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict collection ID format #263

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

roelarents
Copy link
Contributor

Description

restrict the collection (and style) ID format. lowercase, digits, hyphen and underscore are the only allowed chars

PDOK-17366

Type of change

  • Configuration change
  • Breaking change

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@kad-dirc kad-dirc requested a review from rkettelerij December 18, 2024 10:28
@kad-dirc kad-dirc marked this pull request as ready for review December 18, 2024 10:29
@kad-dirc kad-dirc merged commit 0ce5211 into master Dec 18, 2024
5 checks passed
@rkettelerij rkettelerij deleted the pdok-17366-collection-id-regex branch December 18, 2024 14:54
rkettelerij added a commit that referenced this pull request Dec 31, 2024
rkettelerij added a commit that referenced this pull request Dec 31, 2024
fix: for #263 to also support collection IDs with quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants