Permute all variables of the Steane code #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlinm
commented
Dec 16, 2024
Comment on lines
-373
to
+383
| block = Block( | ||
| MeasDecode( | ||
| q=self.d, | ||
| meas_basis=meas_basis, | ||
| meas=self.raw_meas, | ||
| log_raw=self.log_raw, | ||
| log=self.log, | ||
| syn_meas=self.syn_meas, | ||
| pf_x=self.pf_x, | ||
| pf_z=self.pf_z, | ||
| last_raw_syn_x=self.last_raw_syn_x, | ||
| last_raw_syn_z=self.last_raw_syn_z, | ||
| ), | ||
| block = MeasDecode( | ||
| q=self.d, | ||
| meas_basis=meas_basis, | ||
| meas=self.raw_meas, | ||
| log_raw=self.log_raw, | ||
| log=self.log, | ||
| syn_meas=self.syn_meas, | ||
| pf_x=self.pf_x, | ||
| pf_z=self.pf_z, | ||
| last_raw_syn_x=self.last_raw_syn_x, | ||
| last_raw_syn_z=self.last_raw_syn_z, |
There was a problem hiding this comment.
This is just some minor cleanup that comes for the ride in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the current implementation ofPermute-ing classical registers may result in errors before #116 is fixed.One possible solution to this issue is to construct classical logic that swaps the values of classical registers. On further thought, I'll leave this PR as a draft until that is implemented...Classical registers are now swapped "manually" to avoid issue #116