ConstructorDestructorReturn: respect a potentially set php_version config value
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config value PHP4-style constructors - methods with the same name as the class - are no longer regarded as constructors on PHP 8.0 or higher. This adjusts the sniff to respect a potentially set `php_version` configuration value and will prevent the sniff from reporting on PHP4-style constructors when the `php_version` is set to PHP 8.0 or higher. Includes unit tests. Partially fixes 207
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP4-style constructors - methods with the same name as the class - are no longer regarded as constructors on PHP 8.0 or higher.
This adjusts the sniff to respect a potentially set
php_versionconfiguration value and will prevent the sniff from reporting on PHP4-style constructors when thephp_versionis set to PHP 8.0 or higher.Includes unit tests.
Partially fixes #207