CS: add the RequireExplicitBooleanOperatorPrecedence sniff to PHPCS native ruleset #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative ruleset This commit adds the new sniff as introduced in 197 by TimWolla to the PHPCS native ruleset and fixes the few conditions which were ambiguous in this codebase.
TimWolla
reviewed
Feb 4, 2024
| @@ -1727,7 +1727,7 @@ protected function tokenize($string) | |||
| || (stripos($newContent, '0b') === 0 && bindec(str_replace('_', '', $newContent)) > PHP_INT_MAX) | |||
| || (stripos($newContent, '0o') === 0 && octdec(str_replace('_', '', $newContent)) > PHP_INT_MAX) | |||
| || (stripos($newContent, '0x') !== 0 | |||
| && stripos($newContent, 'e') !== false || strpos($newContent, '.') !== false) | |||
| && (stripos($newContent, 'e') !== false || strpos($newContent, '.') !== false)) | |||
There was a problem hiding this comment.
Unless it's too early in the morning and I misread this, it even caught a bug in here 🙌
There was a problem hiding this comment.
I thought so too when I made the change, but there is a test for this code and it passed before and after 🤷🏻♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the new sniff as introduced in #197 by @TimWolla to the PHPCS native ruleset and fixes the few conditions which were ambiguous in this codebase.
Suggested changelog entry
N/A
Related issues/external references
Also see #197