-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strikethrough not working in v0.16.0 #1693
Comments
Can you please share more details. I could not replicate this issue in v0.16.0. |
Tested with version 0.17.0 and works correctly. |
Through a question on Stackoverflow, I managed to reproduce this with Ubuntu: 20.04 After messing about with the block (in the document.xml)...
I found that if you remove the |
I got the same problem. Solved it by downgrading to 0.15.0 |
maybe the function PhpWord/Style/AbstractStyle:: setPairedVal() should set the second value to null and not false |
As stated in PHPOffice#1722 and PHPOffice#1693 `setPairedVal` sets DoubleStrikethrough to false which does not equal `null` This change may somehow infer with 54e7c6d but as no tests could be found it is hard to say what would possibly break
Describe the Bug
Strikethrough is no longer working in version 0.16.0, it is working in version 0.15.0
Steps to Reproduce
Expected Behavior
In the above example 'Hello World!' should have the
strikethroughformatting applied.Using "composer require phpoffice/phpword" to install the PHPWord results in strikethrough not being applied. However using "composer require phpoffice/phpword:0.15.0" to install the PHPWord does apply strikethrough.
Context
Ubuntu: 19.04
PHP Version: 7.2.19
LibreOffice: 6.2.5.2
The text was updated successfully, but these errors were encountered: