Fix: different footer for first page #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample 12 shows how to add a different header for the first page:
This is supposed to work also for footers (since
Header
itself is a subclass ofFooter
), but it's currently broken becauseSection::hasDifferentFirstPage()
only checks if a first-page specific header exists, but doesn't check for a first-page specific footer, too.This PR adds the missing check, fixing the rendering of footers with type
Footer::FIRST
.