Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for fixed tableLayout, allowing to use fixed width columns in tables #1276

Closed
wants to merge 2 commits into from

Conversation

ekopach
Copy link

@ekopach ekopach commented Feb 9, 2018

Added the function to fix the width of columns in tables, when text very long and without delimiters.

  • I have run composer check and no errors were reported
  • The new code is covered by unit tests
  • I have update the documentation to describe the changes

@troosan troosan changed the title Added the function to fix the width of columns in tables, when text very long and without delimiters. Added support for fixed tableLayout, allowing to use fixed width columns in tables Feb 10, 2018
@troosan
Copy link
Contributor

troosan commented Feb 10, 2018

@ekopach actually, this is already implemented in #841, which has not yet been merged.

@ekopach
Copy link
Author

ekopach commented Feb 11, 2018

Oh, thanks. Sorry, I have not seen.

@ekopach ekopach closed this Feb 11, 2018
@samimussbach
Copy link

@troosan I could test and review one of the PRs as we have the same issue. Which one do you prefer?

@troosan
Copy link
Contributor

troosan commented Feb 12, 2018

@samimussbach I don't really have a preference. This solution seems simpler, as only 2 values are possible and 1 the default value, I guess just a boolean is enough.
Both PR are missing unit test, doc, ... though :-S
It would also be nice to immediately implement the reader for it.

@troosan
Copy link
Contributor

troosan commented Feb 13, 2018

@samimussbach please check out the following #1281

@samimussbach
Copy link

You where faster than me, nice. Will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants