Add parsing of html image in base64 format #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2018 18:22
|
@jgpATs2w could you please add test for the new uncovered lines? |
|
Hi @troosan coverage in Html.php is now 100% |
troosan
changed the title
troosan
approved these changes
May 30, 2018
src/PhpWord/Shared/Html.php
Outdated
|
|
||
| $match = array(); | ||
| preg_match('/data:image\/(\w+);base64,(.+)/', $src, $match); | ||
|
|
||
| $src = $imgFile = self::$imgdir . uniqid() . '.' . $match[1]; | ||
| $src = $imgFile = $tmpDir . uniqid() . '.' . $match[1]; | ||
|
|
||
| $ifp = fopen($imgFile, 'wb'); |
There was a problem hiding this comment.
fopen() can return false if it fails to open the file.
see https://scrutinizer-ci.com/g/PHPOffice/PHPWord/inspections/1f0e808d-f874-4a64-9778-f459477f4d58/issues/files/src/PhpWord/Shared/Html.php?status=new&orderField=path&order=asc&honorSelectedPaths=0
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved parseImage from HTML:
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reportedDon't know how to update the documentation, I've updated the comments ahead the functions.