Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ext-zip for development #1419

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Require ext-zip for development #1419

merged 2 commits into from
Jul 13, 2018

Conversation

jjok
Copy link
Contributor

@jjok jjok commented Jul 8, 2018

Description

ext-zip seems to be required for development, but isn't specified in composer.json.

There were 2 failures:

1) PhpOffice\PhpWord\TemplateProcessorTest::testXslStyleSheetCanNotBeAppliedOnFailureOfSettingParameterValue
Failed asserting that exception of type "Error" matches expected exception "\PhpOffice\PhpWord\Exception\Exception". Message was: "Class 'ZipArchive' not found" at
/home/jonathan/Workspace/PHPWord/src/PhpWord/Shared/ZipArchive.php:134
/home/jonathan/Workspace/PHPWord/src/PhpWord/TemplateProcessor.php:88
/home/jonathan/Workspace/PHPWord/tests/PhpWord/TemplateProcessorTest.php:122
.

2) PhpOffice\PhpWord\TemplateProcessorTest::testXslStyleSheetCanNotBeAppliedOnFailureOfLoadingXmlFromTemplate
Failed asserting that exception of type "Error" matches expected exception "\PhpOffice\PhpWord\Exception\Exception". Message was: "Class 'ZipArchive' not found" at
/home/jonathan/Workspace/PHPWord/src/PhpWord/Shared/ZipArchive.php:134
/home/jonathan/Workspace/PHPWord/src/PhpWord/TemplateProcessor.php:88
/home/jonathan/Workspace/PHPWord/tests/PhpWord/TemplateProcessorTest.php:144
.

ERRORS!
Tests: 574, Assertions: 1413, Errors: 133, Failures: 2, Skipped: 1.

@coveralls
Copy link

coveralls commented Jul 8, 2018

Coverage Status

Coverage remained the same at 94.908% when pulling d476f7a on jjok:require-zip-for-dev into 4fa9455 on PHPOffice:develop.

@troosan
Copy link
Contributor

troosan commented Jul 9, 2018

I guess that true for all dependencies defined in the "suggest" section.

@jjok
Copy link
Contributor Author

jjok commented Jul 9, 2018

Ah, yeah, probably. I'll have a look.

@jjok
Copy link
Contributor Author

jjok commented Jul 9, 2018

What's the deal with "ext-gd2"? Is that a requirement? "mpdf/mpdf" seems to require "ext-gd".

I think I'll put that in the dev requirements, rather than 2.

@troosan troosan merged commit 94cf1ae into PHPOffice:develop Jul 13, 2018
@Rar9
Copy link

Rar9 commented Jul 12, 2019

I got

php -i | grep "GD library Version"
GD library Version => 2.2.5

and also the Complained for ext-gd2 . What to fix to get ride of this notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants