Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Title Writer loses text when Title contains a TextRun instead a string. #1436

Merged
merged 1 commit into from
Jul 19, 2018
Merged

HTML Title Writer loses text when Title contains a TextRun instead a string. #1436

merged 1 commit into from
Jul 19, 2018

Conversation

begnini
Copy link
Contributor

@begnini begnini commented Jul 18, 2018 •
edited by troosan
Loading

Description

When the text content of a Title is a TextRun, the writer is losing the text, returning a empty <h1>.
Fixes #1435

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@troosan troosan changed the title Fix Writer losing text when Title contains a TextRun instead a string. HTML Title Writer loses text when Title contains a TextRun instead a string. Jul 18, 2018
@troosan troosan added this to the v0.16.0 milestone Jul 18, 2018
@troosan troosan merged commit 18c26f9 into PHPOffice:develop Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@begnini @troosan