Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non auto line spacing #1508

Merged
merged 2 commits into from
Nov 17, 2018
Merged

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Nov 17, 2018

Description

When setting the line spacing, 240 twips are being added by default. This should only be done when the lineRule is AUTO. In all other cases the actual value should be used.

Fixes #1505

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@troosan troosan merged commit 49eb9d1 into PHPOffice:develop Nov 17, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.838% when pulling eaf027b on troosan:fix_non_auto_line_spacing into ea6edf9 on PHPOffice:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants