Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To support PreserveText inside sub container #1637

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

bhattnishant
Copy link

@bhattnishant bhattnishant commented Jun 3, 2019

Description

if we use PreserveText inside table or special characters, issue fixed
Relavent
https://stackoverflow.com/questions/33070424/phpword-cannot-add-preservetext-in-section

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@troosan
Copy link
Contributor

troosan commented Jun 13, 2019

@bhattnishant Can you fix the failing test please?

@troosan troosan added this to the v0.17.0 milestone Jun 13, 2019
@troosan troosan changed the base branch from master to develop June 13, 2019 22:11
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.63% when pulling d7ed18c on bhattnishant:master into fe531ca on PHPOffice:develop.

@tidalgo22
Copy link

@troosan If you don't mind me asking. When can the v.0.17.0 be release? I'm hoping to get this fix asap. Thank you

@troosan
Copy link
Contributor

troosan commented Jul 10, 2019

@troosan If you don't mind me asking. When can the v.0.17.0 be release? I'm hoping to get this fix asap. Thank you

I'm hoping to release it still this month, I've been quite busy these last weeks!

@tidalgo22
Copy link

@troosan If you don't mind me asking. When can the v.0.17.0 be release? I'm hoping to get this fix asap. Thank you

I'm hoping to release it still this month, I've been quite busy these last weeks!

I hope it would be this month.
Thank you and have great day.

@troosan troosan merged commit 487622b into PHPOffice:develop Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants