Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change private to protected to be able extending class Html #1646

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Change private to protected to be able extending class Html #1646

merged 2 commits into from
Aug 8, 2019

Conversation

SpinyMan
Copy link
Contributor

@SpinyMan SpinyMan commented Jul 3, 2019

No description provided.

@SpinyMan SpinyMan changed the title Change private to protected to extend class Html Change private to protected to be able extending class Html Jul 3, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.63% when pulling 415bdb3 on SpinyMan:develop into fe531ca on PHPOffice:develop.

@troosan troosan added this to the v0.17.0 milestone Jul 10, 2019
@Dwarfex
Copy link

Dwarfex commented Aug 5, 2019

@troosan What is needed to merge this?

@troosan troosan merged commit 24d120b into PHPOffice:develop Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SpinyMan @coveralls @Dwarfex @troosan