Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apt-get crash in Travis CI for PHP 5.3 #1707

Merged
merged 2 commits into from
Sep 1, 2019

Conversation

mdupont
Copy link
Contributor

@mdupont mdupont commented Aug 28, 2019

Description

Fixes the crash when calling apt-get update in PHP 5.3 environment in Travis CI. Since the culprit is a 3rd party repo for MongoDB and that we don't need MongoDB, I just remove the repo definition so apt-get doesn't try to connect to it.

Fixes #1706

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

coveralls commented Aug 28, 2019

Coverage Status

Coverage remained the same at 94.606% when pulling 7231176 on mdupont:fix-travis-ci into 85e9144 on PHPOffice:develop.

@mdupont
Copy link
Contributor Author

mdupont commented Aug 28, 2019

Travis build worked as expected, but is still reported as failed because of phpmd warnings that were already existing in the code in the develop branch, nothing related to this PR.

@0b10011
Copy link
Contributor

0b10011 commented Aug 28, 2019

I bumped the dist to xenial in #1669 and everything passed without bumping memory or anything. Mind you, it also has already bumped the minimum to PHP 7.0 and code/tests has been fixed accordingly.

@mdupont
Copy link
Contributor Author

mdupont commented Aug 30, 2019

If requirements get bumped to PHP >= 7.0 (and we can benefit from the enhanced type declarations), then indeed there won't be any issue anymore :-)

@troosan troosan added this to the v0.17.0 milestone Sep 1, 2019
@troosan troosan merged commit 5b34391 into PHPOffice:develop Sep 1, 2019
@stephanvierkant
Copy link

stephanvierkant commented Nov 25, 2019

Wait, does this library still support PHP versions from the middle ages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Travis CI pipeline is broken for PHP 5.3
5 participants