Fix PHPUnit tests on develop branch #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdupont
changed the title
\Symfony\Component\Process\Process refuses being passed a string with version > 5, which is installed with PHP > 7.2.5. It also refuses being passed an array with version < 3.3, which is installed with PHP < 5.5.9. Solved by checking if Process::fromShellCommandLine() exists, which was introduced in version 4.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests are run with a recent version of PHP,
\Symfony\Component\Process\Processcalled inAbstractWebServerEmbeddedTestneeds to be passed an array. When tests are run in an old PHP version (like 5.4), it needs to be passed a string.Tests should pass regardless of the supported PHP version is running them.
Description
Make sure that we use
\Symfony\Component\Process\Process::fromShellCommandLine()if available. If it's not available, it means we are running an older version ofProcesswhere it's safe to pass a string to the constructor.Fixes #1770
Checklist:
composer run-script check --timeout=0and no errors were reported